IBX-9302: Improved default image variations to auto rotate #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamwojs
approved these changes
Jan 30, 2025
tbialcz
approved these changes
Jan 31, 2025
pawlakadrian
force-pushed
the
IBX-9302-image-variation-auto-rotate-fix
branch
from
dbbd6c1 to
046203a
Compare
|
|
QA Approved on DXP Commerce 4.6.16 |
mikadamczyk
approved these changes
Feb 14, 2025
konradoboza
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Small improvement that enables auto rotation of the images when using one of the default filters (small, tiny, medium, large). While it is a very small change it still changes the default behavior so maybe we don't want to proceed with this yet. Or maybe have it implemented in a different way.
For this to work after applying the changes on latest Ibexa installation we need to run
php bin/console cache:clearthenphp bin/console liip:imagine:cache:remove -v